Skip to content

Conversation

@carinelebas
Copy link
Member

@carinelebas carinelebas commented Oct 30, 2025

Context

  • Create a new endpoint to autoregister a platform
  • create a new platform_token directive to authenticate on that route. We restrict the permission to authorize platform registration on the targetted orga only.

How to test

  • test the endpoint in apollo sandbox

Related issues

Checklist

Quality

  • I consider this work complete and ready for review
  • I tested all features and edge cases
  • I refactored code where necessary to improve quality
  • I made sure my code meets development guidelines
  • I performed a self-review of my code

Testing

  • I wrote test cases for the relevant use cases (unit, integration or e2e tests)
  • (Bug fixes only) I added tests that reproduce and verify the fix

What tests have been made

  • Unit tests
  • Integration tests
  • E2E tests
  • Local manual tests

Additional information

Any additional context, dependencies, or concerns reviewers should know about.

@codecov
Copy link

codecov bot commented Oct 30, 2025

Codecov Report

❌ Patch coverage is 69.15888% with 66 lines in your changes missing coverage. Please review.
✅ Project coverage is 24.53%. Comparing base (41d210f) to head (fa1dd51).
⚠️ Report is 4 commits behind head on development.

Files with missing lines Patch % Lines
...ive-graphql/validators/platform-token-validator.ts 58.33% 45 Missing ⚠️
apps/portal-api/src/server/initialize.ts 11.76% 15 Missing ⚠️
...les/services/registration/registration.resolver.ts 20.00% 4 Missing ⚠️
...es/services/document/document-download-endpoint.ts 33.33% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #1202      +/-   ##
===============================================
+ Coverage        24.05%   24.53%   +0.47%     
===============================================
  Files              542      544       +2     
  Lines            32490    32684     +194     
  Branches          1403     1445      +42     
===============================================
+ Hits              7816     8018     +202     
+ Misses           24433    24425       -8     
  Partials           241      241              
Files with missing lines Coverage Δ
...portal-api/src/modules/services/contract/domain.ts 100.00% <100.00%> (ø)
.../modules/services/registration/registration.app.ts 96.67% <100.00%> (+0.47%) ⬆️
...dules/services/registration/registration.domain.ts 100.00% <ø> (ø)
...l-api/src/modules/services/service-instance.app.ts 100.00% <ø> (ø)
...pi/src/modules/services/service-instance.domain.ts 31.89% <100.00%> (-0.11%) ⬇️
apps/portal-api/src/portal.const.ts 100.00% <100.00%> (ø)
...ty/directive-graphql/auth-directive.transformer.ts 97.22% <100.00%> (+0.67%) ⬆️
apps/portal-api/src/utils/error/error.code.ts 100.00% <100.00%> (ø)
...es/services/document/document-download-endpoint.ts 26.01% <33.33%> (+1.95%) ⬆️
...les/services/registration/registration.resolver.ts 22.05% <20.00%> (-0.08%) ⬇️
... and 2 more

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41d210f...fa1dd51. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 30, 2025

Summary

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
22 22 0 0 0 0 2m 20s

Insights

Average Tests per Run Total Flaky Tests Total Failed Slowest Test (p95)
22 0 0 23.7s

Suites

22 passed, 0 failed, and 0 other

Suite Passed Failed Other Duration
✅ app/apps/portal-e2e-tests/tests/tests_files/api/user.spec.ts
        ✅ should prevent user to update another one when he does not have MANAGE_ACCESS
        ✅ should allow user to update another one when he has ADMINISTRATE_ORGANIZATION
        ✅ should allow user to update another one when he has MANAGE_ACCESS
✅ 3 ❌ 0 ⏭️ 0 4.9s
✅ app/apps/portal-e2e-tests/tests/tests_files/capabilities.spec.ts
        ✅ Should add subscription with capabilities
✅ 1 ❌ 0 ⏭️ 0 23.7s
✅ app/apps/portal-e2e-tests/tests/tests_files/csv-feeds.spec.ts
        ✅ Should add CSV Feed
        ✅ Should delete CSV Feed from the list
        ✅ Should delete CSV Feed from the detailed page
✅ 3 ❌ 0 ⏭️ 0 24.4s
✅ app/apps/portal-e2e-tests/tests/tests_files/custom-dashboards.spec.ts
        ✅ Should add custom dashboard
        ✅ Should see the custom dashboard on public page
        ✅ Should edit a custom dashboard
✅ 3 ❌ 0 ⏭️ 0 26.2s
✅ app/apps/portal-e2e-tests/tests/tests_files/document.spec.ts
        ✅ should perform complete CRUD operations on documents
✅ 1 ❌ 0 ⏭️ 0 4.5s
✅ app/apps/portal-e2e-tests/tests/tests_files/one-click-deploy.spec.ts
        ✅ should send telemetry event
✅ 1 ❌ 0 ⏭️ 0 5.8s
✅ app/apps/portal-e2e-tests/tests/tests_files/organizations.spec.ts
        ✅ should perform complete CRUD operations on organizations
✅ 1 ❌ 0 ⏭️ 0 5.6s
✅ app/apps/portal-e2e-tests/tests/tests_files/profile.spec.ts
        ✅ should update user profile information
✅ 1 ❌ 0 ⏭️ 0 4.8s
✅ app/apps/portal-e2e-tests/tests/tests_files/public/redirections.spec.ts
        ✅ should redirect user between public pages and login page
✅ 1 ❌ 0 ⏭️ 0 2.8s
✅ app/apps/portal-e2e-tests/tests/tests_files/registration.spec.ts
        ✅ should register openAEV platform
        ✅ should register openCTI platform
✅ 2 ❌ 0 ⏭️ 0 6.1s
✅ app/apps/portal-e2e-tests/tests/tests_files/service-management.spec.ts
        ✅ should be able to admin service
✅ 1 ❌ 0 ⏭️ 0 9.3s
✅ app/apps/portal-e2e-tests/tests/tests_files/service-pictures.spec.ts
        ✅ should be able to add pictures to a service
✅ 1 ❌ 0 ⏭️ 0 4.1s
✅ app/apps/portal-e2e-tests/tests/tests_files/user.spec.ts
        ✅ Should perform complete CRUD of users as BYPASS
        ✅ Should only see authorized users
        ✅ Should not edit first and last name as MANAGE_ACCESS user
✅ 3 ❌ 0 ⏭️ 0 17.0s

🎉 No failed tests in this run. | 🍂 No flaky tests in this run.

Github Test Reporter by CTRF 💚

🔄 This comment has been updated

@carinelebas carinelebas merged commit 607c441 into development Nov 7, 2025
24 checks passed
@carinelebas carinelebas deleted the issue/1191 branch November 7, 2025 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants