age: add ExtractHeader, DecryptHeader, and NewInjectedFileKeyIdentity #631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FiloSottile
force-pushed
the
filippo/detached
branch
from
821adc7 to
b671626
Compare
AnomalRoil
approved these changes
Jun 16, 2025
AnomalRoil
left a comment
AnomalRoil
left a comment
There was a problem hiding this comment.
That's a nice addition that will make using it as a library a little bit easier as well, I'm guessing the goal is to allow to have detached headers to have files with just ciphertext and no headers?
|
|
||
| func decryptHdr(hdr *format.Header, identities ...Identity) ([]byte, error) { | ||
| if len(identities) == 0 { | ||
| return nil, errors.New("no identities specified") |
There was a problem hiding this comment.
This is an error that might be worth exporting to allow library users to easily spot it (errors.Is(err, age.ErrNoIdentity)) and issue proper guidance to their users.
Comment on lines
+317
to
+325
| type injectedFileKeyIdentity struct { | ||
| fileKey []byte | ||
| } | ||
|
|
||
| // NewInjectedFileKeyIdentity returns an [Identity] that always produces | ||
| // a fixed file key, such as one returned by [DecryptHeader]. | ||
| func NewInjectedFileKeyIdentity(fileKey []byte) Identity { | ||
| return injectedFileKeyIdentity{fileKey} | ||
| } |
There was a problem hiding this comment.
The name isn't immediately clear imo, maybe fixedFileKeyIdentity would be clearer?
| return nil, ErrIncorrectIdentity | ||
| } | ||
|
|
||
| // ExtractHeader returns a detched header from the src file. |
Contributor
There was a problem hiding this comment.
Typo: s/detched/detached/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.