Feature/uppsf 6584 extend the to string transformer

[ilian2233]

JIRA ticket

[vlasakievft]

suggestion: Maybe would be a good idea to add tests for:

	InNumbers
	Recommended
	RecommendedList

[krasimirakirilova]

praise: The commits are organized in a very good way!
suggestion: The last two commits can be removed.

[vlasakievft]

question: Is it logical to add contenttree.PullquoteType to toSeparate?

[ilian2233]

Good catch. This wouldn't have solved the problem, but I revamped the spacing logic and should be ok now.

[lokendersinghft]

Issue: Here the node should be typecast to contenttree.InNumber and the title field on it should be used.

in, ok := n.(*contenttree.InNumbers)
if !ok {
         return "", errors.New("failed to parse node to InNumbers")
}
 resultChildred, err := transformChildren(in.GetChildren())
if err != nil {
     return "", err
}
return fmt.Sprintf("%s %s", in.Title, resultChildred), nil

Then, we will need an additional case for Definition type.

[lokendersinghft]

suggestion: we should add case: contenttree.TimelineEventChildType node for completeness.

The code works without it because in the default case we are calling n.GetChildren() which internally calls the GetChildren on the embedded node. For example,

func (n *TimelineEventChild) GetChildren() []Node {
     if n.Paragraph != nil {
        return n.Paragraph.GetChildren()
     }
    if n.ImageSet != nil {
       return n.ImageSet.GetChildren()
    }
    return nil
}

So theoretically, we could get rid of all the checks where we return transformNode(n.GetEmbedded()).

[ilian2233]

I think removing the transformNode(n.GetEmbedded()) would be the better approach here.
No need to burden the switch with more cases than needed. What do you think @todor-videv1?

[todor-videv1]

Two options here... if we are sure we can safely remove the n.GetEmbedded()... less is more, I'd advse to leave a comment in the code how the default case is dealing with these embeds though.

If we have even an ounce of doubt, add the additional case like Lokender suggests, and then when we fix the tests, we can do this enhancement.