Draft
Conversation
This means we don't lose the results of the repositories that succeeded and can continue to work on them if we like. Closes #148
ivomurrell
force-pushed
the
error-handling
branch
from
4fe3521 to
b45f43a
Compare
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the state module to now catch errors in operation handlers. This means we don't lose the results of the repositories that succeeded and can continue to work on them if we like. It feels pretty bad to just drop the errors that are being thrown though. Perhaps we should reconsider whether we want to design the handlers to be propagating errors instead of just logging them and moving on? We already have the logic to only do additional steps on the repositories that ran successfully, so throwing errors up to the state module seems unnecessary.
Closes #148