Only add x-fah-middleware header to routes that have middleware enabled #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathu97
requested review from
Yuangwang,
sjjj986,
jamesdaniels,
annajowang,
blidd-google and
taeold
as code owners
mathu97
changed the title
annajowang
approved these changes
Apr 11, 2025
mathu97
commented
Apr 11, 2025
| } | ||
| // Add the middleware header to all routes for which middleware is enabled | ||
| const middlewareManifest = loadMiddlewareManifest(appPath, distDir); | ||
| const rootMiddleware = middlewareManifest.middleware["/"]; |
There was a problem hiding this comment.
@jamesdaniels My assumption here was that we only need to look at the root key as NextJs now only supports middleware at the root directory. It used to support nested middleware while in beta which is why I think the API is like this.
Similar logic in Opennext AWS adapter: https://github.com/opennextjs/opennextjs-aws/blob/73281c958d43d865fdded0d5d86dd82747365fee/packages/open-next/src/core/routing/util.ts#L160-L174
There was a problem hiding this comment.
Yeah that's a good assumption
jamesdaniels
approved these changes
Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
x-fah-middlewareheader is being added to all routes of an app that has a middleware file.This PR updates the logic to only add
x-fah-middlewareheader to routes that have middleware enabled. This is done by reading themiddleware-manifest.jsonto get the routes that middleware is enabled on, and updating theroutes-manifest.jsonfile with thex-fah-middlewareheaders.