Only add x-fah-middleware header to routes that have middleware enabled - #325
Merged
Conversation
mathu97
marked this pull request as ready for review
April 11, 2025 16:54
mathu97
requested review from
Yuangwang,
annajowang,
blidd-google,
jamesdaniels,
sjjj986 and
taeold
as code owners
April 11, 2025 16:54
mathu97
changed the title
annajowang
approved these changes
Apr 11, 2025
annajowang
left a comment
annajowang
left a comment
Collaborator
There was a problem hiding this comment.
lgtm from me on good looking code
mathu97
commented
Apr 11, 2025
jamesdaniels
approved these changes
Apr 14, 2025
jamesdaniels
pushed a commit
that referenced
this pull request
May 20, 2025
…ed (#325) * only add x-fah-middleware routes to routes that have middleware enabled * start tests * fix bug and fix unit tests * fixup e2e tests * fix lint error * fix e2e * bump adapter version
richwear1307
pushed a commit
to richwear1307/horse-tipping-app
that referenced
this pull request
Feb 27, 2026
…ed (firebase#325) * only add x-fah-middleware routes to routes that have middleware enabled * start tests * fix bug and fix unit tests * fixup e2e tests * fix lint error * fix e2e * bump adapter version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently
x-fah-middlewareheader is being added to all routes of an app that has a middleware file.This PR updates the logic to only add
x-fah-middlewareheader to routes that have middleware enabled. This is done by reading themiddleware-manifest.jsonto get the routes that middleware is enabled on, and updating theroutes-manifest.jsonfile with thex-fah-middlewareheaders.Testing this change locally:
/blahroute.x-fah-middlewareheader only being added to the /blah route