Element SendKeys supports strings for different locales and non-US keaybords#137
Element SendKeys supports strings for different locales and non-US keaybords#137PiotrNestor wants to merge 2 commits intoFlaUI:mainfrom
Conversation
|
@aristotelos |
|
@aristotelos Added now also support for SendKeys with embedded actions and composite actions Added also some UITests with KendKeys embedded actions examples. |
| { | ||
| await _actionsDispatcher.DispatchActionsForString(session, inputId, source, elementSendKeysRequest.Text); | ||
| //await _actionsDispatcher.DispatchActionsForStringUsingFlaUICore(session, inputId, source, elementSendKeysRequest.Text); | ||
| await _actionsDispatcher.DispatchSendKeysUsingFlaUICore(elementSendKeysRequest.Text); |
There was a problem hiding this comment.
I don't really like having two branches of code for dispatching actions... Can't we replace the DispatchActionsForString implementation?
|
There seems to be a conflict here between:
If that is the case, I would first like to have this raised for the WebDriver standard. @PiotrNestor have you tried that? If that attempt has been done and has proved unsuccessfully, we could make a conscious choice to deviate from it and document that very explicitly. |
|
Closing the PR because the unanswered questions have to be resolved first |
@jensakejohansson
@hugoMeier
@aristotelos
@Roemer
@stevemonaco
@bmarroquin
The issue solves the issue as reported here:
#129
The updated implementation: Uses Flaui.Core.Input Keyboard.Type to handle the ElementSendKeys request.
The FlaUI.Core already handles many more characters in strings than the WebDriver does not.
It is possible that ElementSendKeys should handle many more string variants containing for example Selenium Keys.XXX but
Added also some UITests that confirm the updated functionality.
In general it's unclear what Selenium actions are supposed to work in SendKeys
In other words:
In the original implementation this does not work - select the first word in a input element and delete it:
this works in stead
Obviously the above is the same in this PR