-
Notifications
You must be signed in to change notification settings - Fork 21
feat!: Context Values support, getEvaluationResult
#184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 17 commits
Commits
Show all changes
62 commits
Select commit
Hold shift + click to select a range
14bf7cc
wip
khvn26 da5b62b
mapper wip
khvn26 f989a8c
mapper fixes
khvn26 05abbe9
wip + offline handlers
khvn26 9f25722
wip + working build
khvn26 8be5116
wip + fix build errors for tests
khvn26 59583be
test fixes
khvn26 c55c339
wip + fix null contextValue
khvn26 f72f1ff
use correct module
khvn26 e697b61
wip + fix segment tests
khvn26 4dcdaed
fix assertEquals
khvn26 7be7e3d
wip + fix `django_id`
khvn26 c4750b4
fix engine and evaluator tests
khvn26 15155e6
build success
khvn26 bf4dddf
drop Java 8 support
khvn26 9d4b0d8
maybe use git url
khvn26 afdaec0
bump submodule
khvn26 6a7e1c3
delete more code
khvn26 c742ec3
minimise formatting changes
khvn26 89f420a
minimise formatting changes pt. 2
khvn26 d4e5b1e
minimise formatting changes pt. 3
khvn26 d99e9d1
improve formatting, comment
khvn26 b861a72
minimise formatting changes pt. 4
khvn26 4730f9a
remove debugging code
khvn26 bebac37
use latest schemas and engine-test-data
khvn26 c3a8811
cleanup
khvn26 bef6681
use isEmpty
khvn26 b0ad7d7
improve identity override segments docs
khvn26 d12ef3f
improve identity overrides segments keys
khvn26 ec6000e
use stringListTypeRef
khvn26 db248dd
refactor getEvaluationResult, add priority constants
khvn26 c4d35e2
improve docs
khvn26 0e827fc
improve readability
khvn26 3819cd9
Support segment metadata
khvn26 de0362b
improve naming
khvn26 b8ae5ab
support variant priority
khvn26 7764097
prevent illegal state
khvn26 7303aeb
clarify context value getter behaviour
khvn26 c37164b
fix type casting
khvn26 50b4bec
fix boolean coercion
khvn26 b4ee7ff
add test names
khvn26 540832f
use latest test data
khvn26 60d5d9e
cleanup
khvn26 e7cfad5
bump maven-surefire-plugin
khvn26 c5821d9
bring models back
khvn26 711ff13
...but they don't belong to the engine anymore
khvn26 27b4b8e
restore IOfflineHandler
khvn26 000e96c
cleanup to improve diff
khvn26 211c5bd
support feature metadata, unset segments in context
khvn26 8389a90
remove extra FeatureStateModel
khvn26 69f00a4
support setting Flag.featureId via metadata
khvn26 b5889e8
fix
khvn26 3a05d8b
fix `List<String>` coercion
khvn26 ed5e516
improve clarity for `IN`
khvn26 23799be
remove extra hop
khvn26 988d59b
improve naming
khvn26 2dfcbbc
remove extra methods
khvn26 183cdf9
remove null check
khvn26 7d1c948
improve test
khvn26 9c46ddf
save some cycles
khvn26 96d6ca2
encapsulate
khvn26 ccf7dd2
improve logic, test coverage
khvn26 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| [submodule "src/test/java/com/flagsmith/flagengine/enginetestdata"] | ||
| path = src/test/java/com/flagsmith/flagengine/enginetestdata | ||
| url = [email protected]:Flagsmith/engine-test-data.git | ||
| branch = v1.0.0 | ||
| branch = feat/context-values | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.