Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style Guide v1 #253

Merged
merged 18 commits into from
Jan 23, 2025
Merged

Style Guide v1 #253

merged 18 commits into from
Jan 23, 2025

Conversation

PoojaB26
Copy link
Collaborator

Description

Provide a brief overview of what this documentation update is about. Explain what sections or topics are being added or revised.

Linear ticket and magic word Fixes DEVR-24

Type of change

  • Typo fix
  • New feature
  • Enhancement to current docs
  • Removed outdated references
  • Update assets

Copy link

stackblitz bot commented Jan 14, 2025

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@PoojaB26 PoojaB26 changed the title Style Guide Style Guide v1 Jan 14, 2025
@PoojaB26 PoojaB26 marked this pull request as ready for review January 14, 2025 17:35
@github-actions github-actions bot requested a review from pinkeshmars January 14, 2025 17:35
Copy link
Collaborator

@pinkeshmars pinkeshmars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PoojaB26 some nit changes. Also, how about if we mention somewhere on the naming convention for custom functions and actions?

@PoojaB26
Copy link
Collaborator Author

@pinkeshmars

naming convention for custom functions and actions?

What do you mean by actions here? Just for action block names? bc otherwise actions dont have names right?

@pinkeshmars
Copy link
Collaborator

@pinkeshmars

naming convention for custom functions and actions?

What do you mean by actions here? Just for action block names? bc otherwise actions dont have names right?

No, I meant the naming convention for writing custom functions and custom actions in custom code, such as using 'lowerCamelCase.' However, this page primarily focuses on variables rather than method names. Perhaps we could add a small note or piece of information about it for clarity.

@pinkeshmars pinkeshmars self-requested a review January 23, 2025 05:03
@PoojaB26
Copy link
Collaborator Author

No, I meant the naming convention for writing custom functions and custom actions in custom code, such as using 'lowerCamelCase.' However, this page primarily focuses on variables rather than method names. Perhaps we could add a small note or piece of information about it for clarity.

Got it! Yes added a section for functions too.

@PoojaB26 PoojaB26 merged commit 3114584 into main Jan 23, 2025
1 check passed
@PoojaB26 PoojaB26 deleted the pooja/style-guide branch January 23, 2025 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants