Skip to content

Add svg ColorMapper to svg loader #680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

sysint64
Copy link

@sysint64 sysint64 commented Apr 3, 2025

What does this change?

Add possibility to specify color mapper for svg.

Fixes #679 🎯

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
    • Ensure the tests (melos run test)
    • Ensure the analyzer and formatter pass (melos run format to automatically apply formatting)
  • Appropriate docs were updated (if necessary)

@AlexV525
Copy link
Member

AlexV525 commented Apr 15, 2025

We've landed changes that updated most of the generated files. You might need to rebase and regenerate them using the tool provided by #682.

@sysint64
Copy link
Author

@AlexV525 Updated

@sysint64
Copy link
Author

@AlexV525 Is there some issue on my side or is it CI? When I run the following command locally: melos run coverage it works just fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR]: Add svg color mapper
2 participants