Skip to content

Adding initialstates function to RNNs #2541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
CarloLucibello merged 5 commits into from
Dec 10, 2024
Merged

Adding initialstates function to RNNs #2541

CarloLucibello merged 5 commits into from
Dec 10, 2024

Conversation

@MartinuzziFrancesco
Copy link
Contributor

@MartinuzziFrancesco MartinuzziFrancesco commented Dec 5, 2024 •
edited
Loading

Adding initialstates function as per discussion in #2514

PR Checklist

  • Tests are added
  • Entry in NEWS.md
  • Documentation, if applicable

@MartinuzziFrancesco MartinuzziFrancesco changed the title added initialstates Adding initialstates function to RNNs Dec 5, 2024
@codecov
Copy link

codecov bot commented Dec 5, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.81%. Comparing base (74c3a63) to head (48402d7).
Report is 5 commits behind head on master.

Additional details and impacted files 
@@             Coverage Diff             @@
##           master    #2541       +/-   ##
===========================================
+ Coverage   32.69%   65.81%   +33.12%     
===========================================
  Files          34       35        +1     
  Lines        1976     2030       +54     
===========================================
+ Hits          646     1336      +690     
+ Misses       1330      694      -636

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CarloLucibello CarloLucibello reopened this Dec 7, 2024
CarloLucibello
CarloLucibello reviewed Dec 7, 2024
View reviewed changes
@CarloLucibello
Copy link
Member

CarloLucibello commented Dec 7, 2024

It should be defined also for RNN, LSTM, ....

@MartinuzziFrancesco
Copy link
Contributor Author

MartinuzziFrancesco commented Dec 7, 2024

It should be defined also for RNN, LSTM, ....

Ah sorry I was meaning to ask, I'll go forward with that

@MartinuzziFrancesco MartinuzziFrancesco mentioned this pull request Dec 7, 2024
Closed
CarloLucibello
CarloLucibello reviewed Dec 9, 2024
View reviewed changes
CarloLucibello
CarloLucibello reviewed Dec 9, 2024
View reviewed changes
@CarloLucibello
Copy link
Member

CarloLucibello commented Dec 9, 2024 •
edited
Loading

Should test that the Flux.initialstates(rnn) returns what is supposed to return for all layers.

CarloLucibello
CarloLucibello reviewed Dec 9, 2024
View reviewed changes
@CarloLucibello CarloLucibello merged commit 40b7f70 into FluxML:master Dec 10, 2024
9 of 11 checks passed
@CarloLucibello CarloLucibello mentioned this pull request Dec 12, 2024
Open
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CarloLucibello CarloLucibello CarloLucibello approved these changes

Assignees

No one assigned

Labels

enhancement RNN

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MartinuzziFrancesco @CarloLucibello @mcabbott