fix test enzyme #2563
Merged
fix test enzyme #2563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcabbott
reviewed
Dec 31, 2024
| @test g[1].bias ≈ ones(Float32, 4) | ||
| end | ||
| end | ||
| using Enzyme: Enzyme, Duplicated, Const, Active |
Member
There was a problem hiding this comment.
Maybe this PR is a good time to insert an if VERSION < v"1.12-" in front of using Enzyme? Then CI on nightly might start telling us things again.
Member
There was a problem hiding this comment.
Between Enzyme and CUDA, I wonder if we shouldn't move (Flux.jl, Zygote can stay) CI to test on prereleases instead of nightly. The signal-to-noise ratio of testing only nightly is quite low because of how often those two deps are broken on it.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2563 +/- ##
=======================================
Coverage 32.50% 32.50%
=======================================
Files 34 34
Lines 2003 2003
=======================================
Hits 651 651
Misses 1352 1352 ☔ View full report in Codecov by Sentry. |
mcabbott
approved these changes
Dec 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
marks as broken an enzyme test that makes the CI fail. Also, moves the enzyme testing utilities to the
test_gradientsfunction.