fix(onboarding): add more allowed dialect

src/services/projects/create/options.ts

@@ -30,10 +30,15 @@ export function getDialect(options: ProjectCreateOptions): ProjectCreateOptions[
   const { databaseDialect: dialect, databaseConnectionURL: url } = options;
 
   if (dialect) return dialect;
-  if (url?.startsWith('postgres://')) return 'postgres';
-  if (url?.startsWith('mssql://')) return 'mssql';
-  if (url?.startsWith('mongodb')) return 'mongodb';
-  if (url?.startsWith('mysql://') || url?.startsWith('mariadb://')) return 'mysql';
+
+  if (!url) return null;
+
+  const [, extractedDialect] = /(.*):\/\//.exec(url);
+
+  if (['mysql2', 'mysql', 'mariadb'].includes(extractedDialect)) return 'mysql';
+  if (['mssql', 'tedious'].includes(extractedDialect)) return 'mssql';
+  if (['pg', 'postgres', 'postgresql'].includes(extractedDialect)) return 'postgres';
+  if (extractedDialect === 'mongodb') return 'mongodb';
 
   return null;
 }

src/services/schema/update/database.js

@@ -1,3 +1,5 @@
+const { getDialect } = require('../../projects/create/options');
+
 class Database {
   constructor({ assertPresent, mongodb, Sequelize, terminator }) {
     assertPresent({
@@ -27,22 +29,7 @@ class Database {
 
   // eslint-disable-next-line class-methods-use-this
   getDialect(dbConnectionUrl, dbDialect) {
-    if (dbConnectionUrl) {
-      if (dbConnectionUrl.startsWith('postgres://')) {
-        return 'postgres';
-      }
-      if (dbConnectionUrl.startsWith('mysql://')) {
-        return 'mysql';
-      }
-      if (dbConnectionUrl.startsWith('mssql://')) {
-        return 'mssql';
-      }
-      // NOTICE: For MongoDB can be "mongodb://" or "mongodb+srv://"
-      if (dbConnectionUrl.startsWith('mongodb')) {
-        return 'mongodb';
-      }
-    }
-    return dbDialect;
+    return getDialect({ databaseConnectionURL: dbConnectionUrl, databaseDialect: dbDialect });
   }
 
   connectToMongodb(options, isSSL) {

test/commands/projects/create/nosql.test.js

@@ -391,6 +391,7 @@ describe('projects:create:nosql', () => {
                   databaseUser: '',
                   databasePassword: '',
                   databaseSSL: false,
+                  databaseDialect: 'mongodb',
                 },
               },
             ],

test/services/database.unit.test.js

@@ -86,9 +86,9 @@ describe('services > database', () => {
       });
 
       describe('and no dialect is provided', () => {
-        it('should return undefined', () => {
+        it('should return null', () => {
           expect.assertions(1);
-          expect(database.getDialect()).toBeUndefined();
+          expect(database.getDialect()).toBeNull();
         });
       });
     });