Skip to content

Conversation

@Scra3
Copy link
Member

@Scra3 Scra3 commented Mar 8, 2024

Definition of Done

General

  • Write an explicit title for the Pull Request, following Conventional Commits specification
  • Test manually the implemented changes
  • Validate the code quality (indentation, syntax, style, simplicity, readability)

Security

  • Consider the security impact of the changes made

@Scra3 Scra3 force-pushed the proposal-workshop branch from a49ac73 to c5c4a16 Compare March 8, 2024 13:43
@Scra3 Scra3 changed the title chore: proposal to remove dep chore: remove jwt-decode to remove vulnerability Mar 8, 2024
Copy link
Contributor

@SteveBunlon SteveBunlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually ! JWT is also used in tests. By convention we should use libraries from context only.

So, jwt should be added entirely in the context and this change should be propagated everywhere. That's quite some code !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants