Skip to content

Add coment to explain NaN verify #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AlecsFarias
Copy link

@AlecsFarias AlecsFarias commented Jan 11, 2025

Add comment to explain NaN verify

Just a comment to explain that this line is a NaN check. This type of verification can be a little confusing at first glance.

Description

^^

Checklist:

  • All tests are passing
  • Type definitions, if updated, pass both test-ts-defs and test-ts-usage
  • Benchmark performance has not significantly decreased
  • Bundle size has not been significantly impacted
  • The bundle size badge has been updated to reflect the new size

Add comment to explain NaN verify
Copy link

changeset-bot bot commented Jan 11, 2025

⚠️ No Changeset found

Latest commit: 0568785

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

@carbonrobot carbonrobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking for now. We should add this into another code change so we are not releasing a comment as a new version.

@ryan-roemer
Copy link
Member

@carbonrobot -- the other thing to keep in mind is that this section is part of the explicitly copied-and-pasted from fast-deep-equal. We may want to long term consider a rewrite to not follow that model...

@AlecsFarias AlecsFarias changed the title Update index.js Add coment to explain some code Jan 13, 2025
@AlecsFarias AlecsFarias changed the title Add coment to explain some code Add coment to explain NaN verify Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants