fix(native): fix container prop forwarding #3065
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Victory Native's containers are not forwarding props from their respective hooks to the
VictoryContainercomponent.This causes the svg to get clipped because the
viewBoxis being set to0 0 undefined undefined.The native implementation spreads the object returned from the hook as-is, but the hook returns
propsandchildrenas separate properties on the object, so they should be de-structured first like they are for the web implementation.Fixes #2895
Fixes #3063
Type of Change
How Has This Been Tested?
I investigated the issue using the lead from this comment and this Expo Snack.
I did not test the native implementation using a fixture in this repo.
Checklist: (Feel free to delete this section upon completion)