Support specifying backupVersion in Restore Spec #2317
+104
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johscheuer
reviewed
Jul 7, 2025
johscheuer
reviewed
Jul 9, 2025
There was a problem hiding this comment.
We have one backup e2e test case (https://github.com/FoundationDB/fdb-kubernetes-operator/blob/main/e2e/test_operator_backups/operator_backup_test.go), could you add a new test case for the new feature?
millasml
force-pushed
the
add-restore-versionstamp
branch
from
8bdac29 to
9f0e18e
Compare
johscheuer
requested changes
Jul 16, 2025
|
@johscheuer bump on this |
johscheuer
reviewed
Jul 21, 2025
Result of fdb-kubernetes-operator-pr on Linux RHEL 9
|
millasml
force-pushed
the
add-restore-versionstamp
branch
from
2a3460a to
2b2d289
Compare
|
@johscheuer sorry for the delay, I'm back and hoping to get this merged this week. I've rebased and fixed the test, do take a look! |
Result of fdb-kubernetes-operator-pr on Linux RHEL 9
|
millasml
force-pushed
the
add-restore-versionstamp
branch
from
2b2d289 to
87bf03f
Compare
|
@johscheuer is there anything that is blocking this from merging? |
johscheuer
reviewed
Sep 1, 2025
Result of fdb-kubernetes-operator-pr on Linux RHEL 9
|
Result of fdb-kubernetes-operator-pr on Linux RHEL 9
|
johscheuer
reviewed
Sep 10, 2025
| Expect(fdbCluster.GetRange([]byte{prefix}, 25, 60)).Should(Equal(keyValues)) | ||
| }) | ||
|
|
||
| It("should restore the cluster successfully with a restorable version", func() { |
There was a problem hiding this comment.
Suggested change
| It("should restore the cluster successfully with a restorable version", func() { | |
| PIt("should restore the cluster successfully with a restorable version", func() { |
Could you mark this test case as pending until we make it pass?
There was a problem hiding this comment.
got it - updated this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support specifying backupVersion in Restore Spec. Passed into the
-voption infdbrestoreType of change
Discussion
Are there any design details that you would like to discuss further?
Testing
Please describe the tests that you ran to verify your changes. Unit tests?
Manual testing?
Do we need to perform additional testing once this is merged, or perform in a larger testing environment?
Documentation
updated docs/restore_spec.md
Follow-up
Are there any follow-up issues that we should pursue in the future?
Does this introduce new defaults that we should re-evaluate in the future?