Add top-level await support for SSR #2987
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/pikapkg/snowpack/Hp2TjvFHJscYPCYuoyPHvt1WNFQi |
drwpow
approved these changes
Jun 25, 2021
FredKSchott
force-pushed
the
support-top-level-await
branch
from
28f2609 to
13453bb
Compare
🦋 Changeset detectedLatest commit: ec20cf8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
FredKSchott
force-pushed
the
support-top-level-await
branch
from
13453bb to
d272e3a
Compare
FredKSchott
force-pushed
the
support-top-level-await
branch
from
d272e3a to
6f4e134
Compare
FredKSchott
force-pushed
the
support-top-level-await
branch
from
6f4e134 to
ec20cf8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
new Functiontonew AsyncFunction. I played around with a smart picker between the two different Function constructors based on whether top-level await existed in the file or not. But ultimately, the performance cost to walk the ast to detect that didn't outweigh the performance cost of an unnecessary Promise wrapper in non-top-level-await files.This fixes an issue where our SSR parser would error on top-level await due to a parser bug: Error trying to use top-level await? meriyah/meriyah#186 Acorn is slower than meriyah, but feature completeness and stability should be our first priority here. I'd love to add meriyah back as soon as that issue is resolved. And, lets hold off on merging a bit in case they're able to fix the issue.Fixed in meriyah! No longer needed, removed from this PR.Testing
Docs