Update urllib3 to 2.6.0+ #133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This dependency update prevents a malicious compression exploit as documented in CVE-2025-66418. https://nvd.nist.gov/vuln/detail/CVE-2025-66418
AniruddhaKanhere
previously approved these changes
Dec 23, 2025
kstribrnAmzn
force-pushed
the
urllibFix
branch
from
d005f05 to
e3504fe
Compare
AniruddhaKanhere
approved these changes
Dec 23, 2025
Member
Author
|
Note - the link verifier is failing due to microchip's URL returning a 403. This can be fixed in a separate PR as I don't think this is related to the urllib3 dpeendency update. |
rauthsuj
approved these changes
Jan 6, 2026
Member
Author
|
Merging this in to reduce the risk from the CVE. I will continue to debug the microchip link verification issue if it persists. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This dependency update prevents a
malicious compression exploit as
documented in CVE-2025-66418.
Relying on the CI step
test-link-verifierto handle testing. If tests pass then I'd consider this good enough.Issue #, if available:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.