Skip to content

remove redundant function declaration #1241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

laroche
Copy link

@laroche laroche commented Apr 13, 2025

Remove warning message from "gcc -Wredundant-decls" in FreeRTOS_TCP_IP.c.

Checklist:

  • I have tested my changes. No regression in existing tests.
  • I have modified and/or added unit-tests to cover the code changes in this Pull Request.

Related Issue

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Remove warning message from "gcc -Wredundant-decls" in
FreeRTOS_TCP_IP.c.

Signed-off-by: Florian La Roche <[email protected]>
@laroche laroche requested a review from a team as a code owner April 13, 2025 15:52
@tony-josi-aws
Copy link
Member

Thanks @laroche for contributing to FreeRTOS+TCP. The change looks good to me.

I think it will be good to have the -Wredundant-decls option as part of our CI build checks CMakeLists.txt so that similar issues may not be added with future changes.

Do you wish to make those changes or prefer us to do so?

kar-rahul-aws
kar-rahul-aws previously approved these changes Apr 14, 2025
AhmedIsmail02
AhmedIsmail02 previously approved these changes Apr 14, 2025
@laroche
Copy link
Author

laroche commented Apr 16, 2025

Hello Tony Josi,

sounds good, please also add this tion to CI build checks.

best regards,

Florian La Roche

AhmedIsmail02
AhmedIsmail02 previously approved these changes Apr 16, 2025
@AhmedIsmail02
Copy link
Member

@tony-josi-aws Thanks for adding the -Wredundant-decls compiler warning option, as part of the FRI project, we've updated the formatting job to run on ubuntu v22.04 -> https://github.com/FreeRTOS/iot-reference-arm-corstone3xx/blob/bda0d25a92fea54076c8d38e82298a51f17b6ac3/.github/workflows/ci.yml#L69, would it make sense to apply this here as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants