Skip to content

Conversation

HTRamsey
Copy link
Contributor

@HTRamsey HTRamsey commented Jul 30, 2025

Description

  • Fetch latest Eth drivers rather than providing a static set.
  • Allows easy updating in the future, and avoids spelling/formatting CI checks.
  • Also provides some minor fixes/updates due to updating the Eth drivers.
  • Replaces STM32 network interface bug fixes #1253

Test Steps

Checklist:

  • I have tested my changes. No regression in existing tests.
  • I have modified and/or added unit-tests to cover the code changes in this Pull Request.

Related Issue

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@HTRamsey
Copy link
Contributor Author

@bjsowa since you were the one who wrote the cmake part originally, thoughts on this?

@HTRamsey HTRamsey force-pushed the dev-stm32-drivers branch from 206a789 to 586e7f8 Compare July 30, 2025 05:02
@HTRamsey HTRamsey force-pushed the dev-stm32-drivers branch from 586e7f8 to 5d9a53e Compare August 9, 2025 17:08
@HTRamsey HTRamsey marked this pull request as ready for review August 9, 2025 17:08
@HTRamsey HTRamsey requested a review from a team as a code owner August 9, 2025 17:08
@bjsowa
Copy link
Contributor

bjsowa commented Aug 9, 2025

Looks good but would be a bit problematic in my application as I am using nix to build it and I need to have all of the sources available before building it. Is using git submodules instead an option?

@HTRamsey
Copy link
Contributor Author

HTRamsey commented Aug 9, 2025

Either way. I used FetchContent because this repo was already using it elsewhere to get the kernel

@xuelix xuelix requested a review from tony-josi-aws August 12, 2025 19:58
@tony-josi-aws
Copy link
Member

@HTRamsey Thanks for this contribution. Are those tags mentioned in the fetch content the same version of the drivers that are being removed? If it's a newer version, did you get a chance to verify the new drivers?

I see that STM32F4 and F7 got a new driver release (minor version) a few days back.

@HTRamsey
Copy link
Contributor Author

It's a newer version with a few changes. I've only really verified the ethernet files and have no idea about the rest of the HAL drivers because I don't use them. But as far as the ethernet changes go a couple of the changes are actually pretty important fixes to the reception process and the rest are related to PTP so not as important. I've tried the latest H7 and F7, which should translate to the F4 and H5 pretty well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants