Fix: Utilize empty space for playlist queue when Hide Recommended Videos is enabled #6948
Conversation
github-actions
bot
added
the
PR: waiting for review
|
To me areas not lining up is visually displeasing. Would prefer to see #6925 (comment) |
There was a problem hiding this comment.
It breaks the whole layout of the side bar, top bar and settings headers. I can scroll away now
VirtualBoxVM_UfSsZQupHA.mp4
Thumbnail exceeds this line with distraction free setting enabled
Thumbnail goes outside the queue box without the distraction free setting enabled
VirtualBoxVM_7SNWOfCLzI.mp4
efb4f5ff-1298-471a-8973-3d47447115dc
added
PR: changes requested
and removed
PR: waiting for review
|
This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 14 days. |
|
This could be accomplished with pure CSS and |
That's a good point but I think the whole solution isn't very robust and probably the wrong way to go about it. Plus I haven't had any time to work on another solution. |
|
That is valid. My recommendation, when you come back to it, would be to start over and just see if you can accomplish this without touching anything but css. If you don't have time right now, that is completely understandable. Life is busy. |
Fix: Utilize empty space for playlist queue when Hide Recommended Videos is enabled
Pull Request Type
Related issue
closes #6925
Description
Playlist area is expanded the entire height of the sidebar when recommended videos are disabled and viewport is wide enough.
Screenshots
Before:
After:
Additional context
Unsure if modifying the main viewport height or using
@mediaselectors is the best way to go about this, but it's what I came up with and seems okay when tested with different viewport sizes.