Fix: Utilize empty space for playlist queue when Hide Recommended Videos is enabled #6948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
PR: waiting for review
|
To me areas not lining up is visually displeasing. Would prefer to see #6925 (comment) |
efb4f5ff-1298-471a-8973-3d47447115dc
requested changes
Mar 1, 2025
There was a problem hiding this comment.
It breaks the whole layout of the side bar, top bar and settings headers. I can scroll away now
VirtualBoxVM_UfSsZQupHA.mp4
Thumbnail exceeds this line with distraction free setting enabled
Thumbnail goes outside the queue box without the distraction free setting enabled
VirtualBoxVM_7SNWOfCLzI.mp4
efb4f5ff-1298-471a-8973-3d47447115dc
added
PR: changes requested
and removed
PR: waiting for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Utilize empty space for playlist queue when Hide Recommended Videos is enabled
Pull Request Type
Related issue
closes #6925
Description
Playlist area is expanded the entire height of the sidebar when recommended videos are disabled and viewport is wide enough.
Screenshots
Before:
After:
Additional context
Unsure if modifying the main viewport height or using
@mediaselectors is the best way to go about this, but it's what I came up with and seems okay when tested with different viewport sizes.