Fix scroll to seek/change volume/playback rate changing too fast with touchpad #6666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
PR: waiting for review
6 tasks
|
it seems slow but that could be because im testing on a trackpad |
|
Feel free to change the 100ms values to something else to see how it feels |
|
I let the others chime into this one as i find it difficult to evaluate what a good speed for this is |
|
I rarely use trackpad not to mention scrolling |
|
This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 14 days. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Related issue
Closes #6539
Description
wheeltriggered N times more than mouse wheel with smaller delta values to have smooth scrollingThis PR throttles event handler on value change side only (prevent default/stop propagation still called all the time
Screenshots
With 100ms wait time, trackpad
Screen.Recording.2025-01-29.at.10.21.52.mp4
Testing
A) Those without trackpad
See #6539, test with mouse wheel ensure it works similar to/same as before
B) Those with trackpad
#6539
Desktop
Additional context
I tested 50ms wait and it seems too fast
(Too lazy to record that too