-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement content and session PO tokens #6931
base: development
Are you sure you want to change the base?
Conversation
Putting into custom build to test for 1 week+ |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Conflicts have been resolved. A maintainer will review the pull request shortly. |
I don't experience this bug in my regular usage but will start testing this build. |
This comment has been minimized.
This comment has been minimized.
@ArthurKun21 That build is based on the older commits that were using a hardcoded timeout which is no longer present in the latest commits. If you want to help test PRs, please make sure you are actually using the latest changes next time before commenting that something doesn't work for you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested > 1 week
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got several 403 but not frequently and I did not use normal build for a while so no idea if YT doing stuff or this PR causing it |
Implement content and session PO tokens
Pull Request Type
Related issue
Will link it after other devs have confirmed that it solves the issue for them too.
Description
YouTube has switched from just using session based PO tokens that are added to the streaming URLs, which is what we are currently doing, to also introducing content PO tokens which are tied to the video ID added to the
/player
request. This pull request implements that new PO token. Challenges are now fetched from thehttps://www.youtube.com/api/jnn
which is a proxy forjnn-pa.googleapis.com
instead of fetching it directly from the latter URL, which should hopefully help with people's misconfiguring their ad-blocker to blockjnn-pa.googleapis.com
.This will definitely have code conflicts with the potoken proxy pull request, I will resolve the code conflicts in whichever pull request is merged later.
Testing
Open various videos and check that you don't get any 403s or
Error: Error invoking remote method 'generate-po-token'
errors.Desktop