-
-
Notifications
You must be signed in to change notification settings - Fork 585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix grid hover and click issue on smaller screen sizes #2613
Fix grid hover and click issue on smaller screen sizes #2613
Conversation
…will not cover the grid
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
840e2df
to
9ed6c52
Compare
@nohaibogdan1 You can test in that scenario yourself as well by editing source and changing the iframe link. Anyway, even if the website has the header containing the logo, the game will eventually cannibalize the website itself and become one, so there will be no more duplication of logos, plus the game itself gets embedded around the web quite a bit. I've tested and looks fine, except that when hovering the round marker, it causes a lot of flickering of the logo, hex grid and upper right lens thingy changes details like crazy. Using Firefox on Linux. 2024-08-23.19-07-56.mp4 |
9ed6c52
to
1478da4
Compare
@DreadKnight I think I fixed this time for good |
1478da4
to
2950a76
Compare
spaces
added a space, the final frontier
@nohaibogdan1 Tested and merged. Did some small coding consistency as well. Both issues fixed but new issue created as it's problematic during embeds, which will matter, as the game will cannibalize the website itself plus it will get embedded big time across the web, see #2615 for that. Bounty sent -> https://www.mintme.com/explorer/tx/0xc1715df92d24c8827cca4114cc5bd2588563bc80a483aa728cdc593b78e1def0 🪙 |
This fixes issue #2609
My wallet address is 0xb82c1a2192090acf236f691113b2a823a15eb03b
Related to this #2610
The proposed solution is the following:
The only catch is that the logo sometimes gets over the queue. I propose for this to make the logo with a shadow background.
@DreadKnight Can you test this and give me a feedback please ?
Actually I am sure this will NOT work in the context of NOT being in fullscreen mode like how is it in the following screenshot, but I cannot test it . Scratch that, we don't show the brand logo in this situation because it is already there.