-
-
Notifications
You must be signed in to change notification settings - Fork 104
Add log timestamp option to Dio logger settings #418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
azaderdogan
wants to merge
1
commit into
Frezyx:master
Choose a base branch
from
azaderdogan:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced `logTimestamp` setting in `TalkerDioLoggerSettings` to control timestamp logging. - Updated `DioRequestLog`, `DioResponseLog`, and `DioErrorLog` to include timestamp in log messages when `logTimestamp` is enabled.
Contributor
Reviewer's GuideThis PR adds an optional timestamp feature to the Dio logger by introducing a new Sequence diagram for logging with timestamp optionsequenceDiagram
participant App
participant Logger
participant Settings
App->>Logger: Log request/response/error
Logger->>Settings: Check logTimestamp
alt logTimestamp enabled
Logger->>Logger: Add timestamp to log message
else logTimestamp disabled
Logger->>Logger: Log message without timestamp
end
Class diagram for updated TalkerDioLoggerSettings and log classesclassDiagram
class TalkerDioLoggerSettings {
+bool printRequestData
+bool printRequestHeaders
+bool printRequestExtra
+bool logTimestamp
+Set<String> hiddenHeaders
+Function? responseDataConverter
+AnsiPen? requestPen
+AnsiPen? responsePen
+AnsiPen? errorPen
+copyWith(...)
}
class DioRequestLog {
+DioRequestLog(...)
+displayTime(...)
}
class DioResponseLog {
+DioResponseLog(...)
+displayTime(...)
}
class DioErrorLog {
+DioErrorLog(...)
+displayTime(...)
}
TalkerDioLoggerSettings <|-- DioRequestLog
TalkerDioLoggerSettings <|-- DioResponseLog
TalkerDioLoggerSettings <|-- DioErrorLog
File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there - I've reviewed your changes - here's some feedback:
- Consider refactoring the timestamp-appending logic into a shared helper method to reduce duplication across request, response, and error logs.
- It might be helpful to allow customizing the timestamp format or its label via settings to make the logger more flexible and consistent with other fields.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider refactoring the timestamp-appending logic into a shared helper method to reduce duplication across request, response, and error logs.
- It might be helpful to allow customizing the timestamp format or its label via settings to make the logger more flexible and consistent with other fields.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
logTimestampsetting inTalkerDioLoggerSettingsto control timestamp logging.DioRequestLog,DioResponseLog, andDioErrorLogto include timestamp in log messages whenlogTimestampis enabled.Thanks a lot for contributing!
Provide a description of your changes below
#412
Summary by Sourcery
New Features:
logTimestampoption to TalkerDioLoggerSettings to toggle timestamp inclusion in logs