Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Dec 6, 2025

Thanks a lot for contributing!

Response time displayed in TalkerScreen kept increasing on each view because _getResponseTime() was called in generateTextMessage(), recalculating elapsed time from DateTime.now() on every render.

Changes:

  • Calculate responseTime once in constructor initializer list for DioResponseLog and DioErrorLog
  • Store as final int? responseTime field
  • Use stored value in generateTextMessage() instead of recalculating

Tests added:

  • Verify response time remains consistent across multiple generateTextMessage() calls for both response and error logs

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • dl-ssl.google.com
    • Triggering command: /usr/bin/wget wget -qO- REDACTED (dns block)
    • Triggering command: /usr/bin/curl curl -fsSL REDACTED (dns block)
  • esm.ubuntu.com
    • Triggering command: /usr/lib/apt/methods/https /usr/lib/apt/methods/https (dns block)
  • https://storage.googleapis.com/flutter_infra_release/releases/stable/linux/flutter_linux_3.22.3-stable.tar.xz
    • Triggering command: /usr/bin/curl curl -o /tmp/flutter_install.sh REDACTED (http block)
    • Triggering command: /usr/bin/wget wget -qO- REDACTED (http block)
    • Triggering command: /usr/bin/wget wget -q REDACTED (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Original prompt

This section details on the original issue you should resolve

<issue_title>The output of printResponseTime for dio in TalkerScreen is displayed incorrectly</issue_title>
<issue_description>In the latest version, dio has a printResponseTime that can be configured. When I set it to true, its output in the console is accurate. However, when I check the result "Time" in TalkerScreen, it keeps changing and is inconsistent with the console output. Each time TalkerScreen is opened and the same history record is seen, this time is increasing</issue_description>

Comments on the Issue (you are @copilot in this section)


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI changed the title [WIP] Fix incorrect response time output in TalkerScreen Fix printResponseTime display in TalkerScreen showing incorrect/increasing values Dec 6, 2025
Copilot AI requested a review from Frezyx December 6, 2025 07:27
@Frezyx Frezyx marked this pull request as ready for review December 10, 2025 08:01
@Frezyx Frezyx merged commit 5068fee into master Dec 10, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The output of printResponseTime for dio in TalkerScreen is displayed incorrectly

2 participants