Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Doctrine DBAL 4 support #69

Merged
merged 5 commits into from
Sep 26, 2024

Conversation

pschombara
Copy link
Contributor

Added support for doctrine/dbal ^4.

Solves #68

Added support for doctrine/dbal ^4.
@pschombara pschombara changed the title Draft: feature/dbal-v4 Added Doctrine DBAL 4 support Sep 10, 2024
@asanikovich asanikovich self-assigned this Sep 20, 2024
@VitekSkrip
Copy link

Hi!

I forked your PR and met some problems. For example, in src/ClickHouseSchemaManager.php at line 114 need to convert prep_replace return value to integer because \Doctrine\DBAL\Schema\Column setLength expects ?int value

@pschombara
Copy link
Contributor Author

I fixed the most of the PHPStan errors.
But one of them I don't know how to solve it for clickhouse.


Line ClickHouseSchemaManager.php


82 Method FOD\DBALClickHouse\ClickHouseSchemaManager::listTableIndexes()
should return array<string, Doctrine\DBAL\Schema\Index> but returns
array<int, Doctrine\DBAL\Schema\Index>.

@asanikovich asanikovich merged commit f7d0dda into FriendsOfDoctrine:master Sep 26, 2024
2 of 4 checks passed
@asanikovich
Copy link
Member

@pschombara thanks you. I will update github actions, fix phpstan and prepare a new tag.

@asanikovich
Copy link
Member

asanikovich commented Sep 26, 2024

@VitekSkrip
Copy link

Thank u a lot 🥹

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants