-
Notifications
You must be signed in to change notification settings - Fork 88
Sylius 2.x compatibility #304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sylius 2.x compatibility #304
Conversation
|
Hello @shochdoerfer , Thanks for your help. Regards |
|
Sure will do. Give me a few more days. Had some issues getting the build to run locally. Will investigate and provide the fixes. |
59439de to
eff5f1c
Compare
eff5f1c to
f841f8d
Compare
|
@oallain build is green |
|
@UrbiJr in the meantime you could use the branch of our fork directly. That's how we added it to the 2 projects we are currently working on. |
@shochdoerfer hey sorry if I ask here.. any clue why nothing is happening after clicking the |
found a fix: I updated your |
|
@UrbiJr thx for catching this. I had fixed this locally, but never committed :( |
oallain
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's merge it 🎉
Make the plugin compatible with Sylius v2. These changes are not backward compatible mainly due to the Twig/Bootstrap-related changes in Sylius v2.