Skip to content

Conversation

@shochdoerfer
Copy link
Contributor

Q A
Bug fix? no
New feature? no
BC breaks? yes

Make the plugin compatible with Sylius v2. These changes are not backward compatible mainly due to the Twig/Bootstrap-related changes in Sylius v2.

@oallain
Copy link
Member

oallain commented Apr 9, 2025

Hello @shochdoerfer ,

Thanks for your help.
Can you take a look for building failure?
https://github.com/bitExpert-forks/SyliusImportExportPlugin/actions/runs/14294363886/job/40059631905

Regards

@shochdoerfer
Copy link
Contributor Author

Sure will do. Give me a few more days.

Had some issues getting the build to run locally. Will investigate and provide the fixes.

@shochdoerfer shochdoerfer force-pushed the feature/sylius_v2 branch 3 times, most recently from 59439de to eff5f1c Compare April 14, 2025 06:57
@shochdoerfer
Copy link
Contributor Author

@oallain build is green

@UrbiJr
Copy link

UrbiJr commented May 26, 2025

@lsmith77 @oallain can you please merge??

@shochdoerfer
Copy link
Contributor Author

@UrbiJr in the meantime you could use the branch of our fork directly. That's how we added it to the 2 projects we are currently working on.

@UrbiJr
Copy link

UrbiJr commented May 26, 2025

@UrbiJr in the meantime you could use the branch of our fork directly. That's how we added it to the 2 projects we are currently working on.

@shochdoerfer hey sorry if I ask here.. any clue why nothing is happening after clicking the Customer Import button on /admin/customers/ ? Nothing is printed on the web console, nor in the network tab.
I get the same behaviour also for the other entities. I setup the redis_connection_factory service as per config, added config/packages/fos_sylius_import_export.yaml and config/routes/fos_sylius_import_export.yaml

@UrbiJr
Copy link

UrbiJr commented May 26, 2025

@UrbiJr in the meantime you could use the branch of our fork directly. That's how we added it to the 2 projects we are currently working on.

@shochdoerfer hey sorry if I ask here.. any clue why nothing is happening after clicking the Customer Import button on /admin/customers/ ? Nothing is printed on the web console, nor in the network tab. I get the same behaviour also for the other entities. I setup the redis_connection_factory service as per config, added config/packages/fos_sylius_import_export.yaml and config/routes/fos_sylius_import_export.yaml

found a fix: I updated your import_form.html.twig by changing type="button" to type="submit" in order to submit the form.

@shochdoerfer
Copy link
Contributor Author

@UrbiJr thx for catching this. I had fixed this locally, but never committed :(

Copy link
Member

@oallain oallain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge it 🎉

@oallain oallain merged commit 9cfe317 into FriendsOfSylius:master May 31, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants