if cmdr is near a body it'll show the distance from said body to the … by iMouath · Pull Request #12 · FuelRats/EliteDangerousWebJournal

iMouath · 2018-09-06T09:09:36Z

Added a way to view nearby body.
query EDDB through kodeblox api to get body distance from arrival.

…main star.

houndci-bot · 2018-09-06T09:09:53Z

edj.logparser.js

+        case 'StartJump':
+          edjdata.player.pos = {
+            ...edjdata.player.pos,
+            ...logItem,


Expected an assignment or function call and instead saw an expression.
Missing semicolon.
Unrecoverable syntax error. (50% scanned).

houndci-bot · 2018-09-06T09:09:53Z

edj.logparser.js

+          edjdata.player.pos = {
+            ...edjdata.player.pos,
+            ...logItem,
+          };


Unexpected '}'.

houndci-bot · 2018-09-06T09:09:53Z

edj.logparser.js

+          break;
+        case 'StartJump':
+          edjdata.player.pos = {
+            ...edjdata.player.pos,


Expected '}' to match '{' from line 189 and instead saw '...'.
Missing semicolon.

houndci-bot · 2018-09-06T09:09:53Z

edj.logparser.js

+          };
+          break;
+        case 'StartJump':
+          edjdata.player.pos = {


Expected '}' to match '{' from line 1 and instead saw 'edjdata'.

houndci-bot · 2018-09-06T09:09:54Z

edj.logparser.js

+            ...logItem,
+          };
+          break;
+        case 'StartJump':


Expected '}' to match '{' from line 3 and instead saw 'case'.
Expected an assignment or function call and instead saw an expression.
Missing semicolon.
Expected '}' to match '{' from line 2 and instead saw ':'.

houndci-bot · 2018-09-06T09:09:54Z

edj.logparser.js

+        case 'Location':
+          edjdata.player.pos = {
+            ...edjdata.player.pos,
+            ...logItem,


Expected an assignment or function call and instead saw an expression.
Missing semicolon.

houndci-bot · 2018-09-06T09:09:54Z

edj.logparser.js

+          edjdata.player.pos = {
+            ...edjdata.player.pos,
+            ...logItem,
+          };


Unexpected '}'.
Unnecessary semicolon.

houndci-bot · 2018-09-06T09:09:55Z

edj.logparser.js

+          break;
+        case 'Location':
+          edjdata.player.pos = {
+            ...edjdata.player.pos,


Expected '}' to match '{' from line 183 and instead saw '...'.
Missing semicolon.

houndci-bot · 2018-09-06T09:09:55Z

edj.getdistance.js

+        const jsonResponse = JSON.parse(req.responseText);
+        console.log(jsonResponse.docs[0].distance_to_arrival);
+        edjdata.player.pos.DistanceToArrival = jsonResponse.docs[0].distance_to_arrival;
+        edjGui.updateGui();


'edjGui' is not defined.

houndci-bot · 2018-09-06T09:09:55Z

edj.getdistance.js

+/* edjGui */
+edjGetdistance = {
+  request(sysname) {
+    const req = new XMLHttpRequest();


'XMLHttpRequest' is not defined.

itssimple

Would it be too much to ask, to change the API, to use the one we at FuelRats have instead?

https://github.com/FuelRats/EDDB_JsonAPI
https://colinhiggs.github.io/pyramid-jsonapi/client.html#filter-examples

iMouath · 2018-09-06T20:13:13Z

Sure thing, I will read on the FuelRats API docs, and revise the PR :)

itssimple · 2018-09-06T20:14:08Z

Thanks a bunch! :) (I don't know if the docs are working, but it should be fairly simple.)

https://system.api.fuelrats.com is the domain you'd want to use at least. ^^

You can do searches like this:
https://system.api.fuelrats.com/systems?filter[bodies.name:like]=Fuelum*&include=bodies,bodies.stations&fields[systems]=name,is_populated&fields[stations]=name,max_landing_pad_size,distance_to_star&fields[bodies]=name,group_name,type_name,distance_to_arrival

iMouath · 2018-09-07T03:38:31Z

Hmm, is the filter case sensitive?
this will return true data:
https://system.api.fuelrats.com/systems?filter[bodies.name:like]=Sol
this won't:
https://system.api.fuelrats.com/systems?filter[bodies.name:like]=SOL

and how would I escape spaces, since %20 does't work either.

UncleClapton · 2018-09-07T04:42:58Z

Butting in here as I have prior experience with our systems API.

To answer your first question, like is indeed case sensitive. ilike is the case insensitive of like.

As a word of warning, I would avoid using like/ilike filters as they are extremely slow and quite taxing on the server. Since we're never really dealing with partial names, I would recommend using the eq filter instead.

As for the case sensitivity problem you're seeing... I think there is something up with the field selector you're using that is causing the system data to only appear when the name is in lower case. Weird...

With all this in mind, what you probably want to be using is this query:
/systems?filter[name:eq]=${encodeURIComponent(system.toUpperCase())}&include=bodies.stations

EDIT: punctuation and updating the query provided

itssimple · 2018-09-07T04:52:07Z

Yeah, my experience with the system-api we have, is what I learned from trial and error during the 20 minutes I poked at it yesterday. :) So better listen to @UncleClapton, he probably knows better than me. ^^

iMouath · 2018-09-07T05:29:21Z

@UncleClapton Thank you for clarifying that :)

Since @itssimple is readying from the journal all systems and bodies are uppercase.
But I just tested more systems and they work however some don't and I cannot find what is the cause exactly

No results for UGP 184 2"

Works perfectly:

notice that It doesn't even require encoding them.

edit: fix urls
edit note: I'm querying the bodies not the systems.

edit3: https://system.api.fuelrats.com/systems/18158/bodies shows no bodies
So I guess database doesn't have them? They do exist in EDDB however.

UncleClapton · 2018-09-07T05:40:12Z

@iMouath looks like UGP 184 does not have any known bodies in our database. If you look at the system (https://system.api.fuelrats.com/systems?filter[name:eq]=UGP%20184&include=bodies) you will notice that there are no bodies that exist.

iMouath · 2018-09-07T05:44:10Z

@UncleClapton thank you so much for confirming that lol ... that was fun.

@itssimple It's up to you, I already wrote the for both API the in-house and https://elitebgs.kodeblox.com/api/eddb/v3/

UncleClapton · 2018-09-07T05:46:29Z

@iMouath yeah idk how long ago our bodies table was updated, but I'll ask if we can get a comprehensive update done

Btw, if you're interested in squeaking with us in real time, our IRC is always open! Feel free to hop on https://kiwi.fuelrats.com/ and ping me (Clapton) so I can get you into our semi-public dev room. If you're already familiar with IRC, you can point your client to irc.fuelrats.com:+6697

if cmdr is near a body it'll show the distance from said body to the …

0cb2824

…main star.

iMouath requested a review from itssimple as a code owner September 6, 2018 09:09

houndci-bot reviewed Sep 6, 2018

View reviewed changes

itssimple suggested changes Sep 6, 2018

View reviewed changes

Conversation

iMouath commented Sep 6, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

itssimple left a comment

Choose a reason for hiding this comment

Uh oh!

iMouath commented Sep 6, 2018

Uh oh!

itssimple commented Sep 6, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

iMouath commented Sep 7, 2018

Uh oh!

UncleClapton commented Sep 7, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

itssimple commented Sep 7, 2018

Uh oh!

iMouath commented Sep 7, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

UncleClapton commented Sep 7, 2018

Uh oh!

iMouath commented Sep 7, 2018

Uh oh!

UncleClapton commented Sep 7, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

itssimple commented Sep 6, 2018 •

edited

Loading

UncleClapton commented Sep 7, 2018 •

edited

Loading

iMouath commented Sep 7, 2018 •

edited

Loading

UncleClapton commented Sep 7, 2018 •

edited

Loading