-
Notifications
You must be signed in to change notification settings - Fork 26
feat(UserNicknamesPanel): add ability to set IRC display nickname #449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
SuperManifolds
wants to merge
7
commits into
develop
Choose a base branch
from
supermanifolds/448
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
57091d6
feat(UserNicknamesPanel): add ability to set IRC display nickname
SuperManifolds 82a1a37
chore: add changeset for IRC display nickname feature
SuperManifolds 1d5a845
fix(UserNicknamesPanel): remove trailing spaces to fix eslint
SuperManifolds d6d113d
refactor(UserNicknamesPanel): address PR review feedback
SuperManifolds 01f2d22
Merge branch 'develop' into supermanifolds/448
SuperManifolds 7bb727c
fix: resolve eslint and stylelint issues
SuperManifolds 64c2433
refactor(UserNicknamesPanel): improve error handling and icon impleme…
SuperManifolds File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| --- | ||
| "fuelrats.com": minor | ||
| --- | ||
|
|
||
| Add ability to set IRC display nickname in user profile | ||
|
|
||
| - Users can now select which of their registered IRC nicknames should be their display nickname | ||
| - Added a star icon button next to each non-display nickname to set it as the display nickname | ||
| - The current display nickname is indicated by the absence of action buttons | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -36,6 +36,7 @@ export { | |
| faSignature, | ||
| faSpaceShuttle, | ||
| faSpinner, | ||
| faStar, | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. we also need to provide the regular version, since this only provides the solid version. Sorry I forgot we don't actually have this icon pack in here yet. without adding it the icon won't load properly.
To fix:
export {
faStar as farStar,
} from '@fortawesome/free-regular-svg-icons' |
||
| faSync, | ||
| faTimes, | ||
| faTimesCircle, | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Uh oh!
There was an error while loading. Please reload this page.