Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Prevent the Weekend 1's Story Menu Title from eating up too much space from other Titles #4348

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

KoloInDaCrib
Copy link
Contributor

@KoloInDaCrib KoloInDaCrib commented Mar 18, 2025

Does this PR close any issues? If so, link them below.

Fixes #2982

Briefly describe the issue(s) fixed.

Had to use a different function for rearranging title positions lol!

Include any relevant screenshots or videos.

2025-03-18.20-10-01.mp4

(Lesson 1's title graphic initially had some empty space above the actual title because of this bug so I trimmed it down in photoshop)

@github-actions github-actions bot added status: pending triage Awaiting review. pr: haxe PR modifies game code. size: medium A medium pull request with 100 or fewer changes. labels Mar 18, 2025
@Hundrec Hundrec added the type: minor bug Involves a minor bug or issue. label Mar 18, 2025
Copy link

@charlesisfeline charlesisfeline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was literally unplayable without this pr, thank you so much!

Copy link
Collaborator

@AbnormalPoof AbnormalPoof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes please

Copy link

@trayfellow trayfellow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Friday Night Funkin' if it was good

Copy link
Contributor

@NotHyper-474 NotHyper-474 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works.

2025-03-18.19-12-56.mp4

@trayfellow
Copy link

Fix so good I ported it directly to hscript just to test it (and yeah it works)

2025-03-20.13-00-31.online-video-cutter.com.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: haxe PR modifies game code. size: medium A medium pull request with 100 or fewer changes. status: pending triage Awaiting review. type: minor bug Involves a minor bug or issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants