Skip to content

[BUGFIX] Chart Editor - Character icon clickable in playstate fix #4350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

Lasercar
Copy link
Contributor

@Lasercar Lasercar commented Mar 19, 2025

Does this PR close any issues? If so, link them below.

Fixes #5294
Not merged fast enough...

Briefly describe the issue(s) fixed.

The character icon in the chart editor was still clickable while in the playstate - it wasn't checking if the chart editor state was actually currently active or not.

Include any relevant screenshots or videos.

@github-actions github-actions bot added the status: pending triage Awaiting review. label Mar 19, 2025
@Lasercar Lasercar changed the title Character icon clickable in playstate fix Chart editor - Character icon clickable in playstate fix Mar 19, 2025
@github-actions github-actions bot added size: small A small pull request with 10 or fewer changes. pr: haxe PR modifies game code. labels Mar 19, 2025
@Hundrec Hundrec added type: minor bug Involves a minor bug or issue. topic: chart editor Related to the operation of the Chart Editor. labels Mar 19, 2025
Copy link
Member

@Hundrec Hundrec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No more lag machine

@EliteMasterEric EliteMasterEric added size: tiny A tiny pull request with 4 or fewer changes. and removed size: small A small pull request with 10 or fewer changes. labels May 14, 2025
@Lasercar Lasercar changed the title Chart editor - Character icon clickable in playstate fix [BUGFIX] Chart Editor - Character icon clickable in playstate fix Jun 19, 2025
@Lasercar Lasercar changed the base branch from develop to main July 6, 2025 09:14
@Lasercar Lasercar changed the base branch from main to develop July 6, 2025 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: haxe PR modifies game code. size: tiny A tiny pull request with 4 or fewer changes. status: pending triage Awaiting review. topic: chart editor Related to the operation of the Chart Editor. type: minor bug Involves a minor bug or issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug Report: Character window still opens in game when testing a chart
3 participants