[ENHANCEMENT] [MODDING] QOL changes to strumlines #4388
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does this PR close any issues? If so, link them below.
Closes #2616
Briefly describe the issue(s) fixed.
This PR changes
initStrumlines()
so that it now takes a note style ID instead of anoteStyle
, along with the option to disable the fade.Additionally, changes were made so changing a strumline's notestyle mid-song is way easier! Just change
noteStyleId
and the graphics will be updates automatically. Technically you could already do this before but it was very inefficient:pr.showcase.mp4
Code snippet:
This doesn't break note kinds that use another notestyle (here the notekind has the
funkin
notestyle):it_works_fine.mp4
Include any relevant screenshots or videos.
erect.sampler.thing.mp4
Issues
Please let me know if you encounter issues with this PR!! I only tested this with the pixel notestyle.
Also note that this will break mods that use
initStrumlines()
.