[POLISH] Fix double hold note confirm animations / small StrumlineNote rewrite #6391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
status: pending triage
JackXson-Real
approved these changes
Nov 2, 2025
Contributor
JackXson-Real
left a comment
JackXson-Real
left a comment
There was a problem hiding this comment.
I'm JackXson-Real, and I approve this Pull Request!
PurSnake
changed the title
Hundrec
changed the title
PurSnake
force-pushed
the
touch-those-strumnotes
branch
3 times, most recently
from
b8060b8 to
157c104
Compare
PurSnake
force-pushed
the
touch-those-strumnotes
branch
from
65b27e9 to
feb9638
Compare
github-actions
bot
added
size: tiny
github-actions
bot
added
size: medium
PurSnake
force-pushed
the
touch-those-strumnotes
branch
from
4cb1486 to
d995b8f
Compare
PurSnake
changed the title
PurSnake
force-pushed
the
touch-those-strumnotes
branch
from
d995b8f to
1f33ad9
Compare
PurSnake
force-pushed
the
touch-those-strumnotes
branch
from
1f33ad9 to
9fd5a48
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked Issues
#6379
Description
I slightly rewrote StrumlineNote to run confirm-hold animation, only if there's correct data is present for that animation. (if it not looped)
Otherwise we just hold last frame of confirm animation 😁
Also added
holdingvariable to prevent unnecessary actions.Screenshots/Videos
Before:
After:
