[BUGFIX] Fix Results Screen Song Text Being Framerate Dependent #6476
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
status: pending triage
|
Elapsetic |
AbnormalPoof
added
type: minor bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue with the results screen where the song text scrolls at a speed that isn't framerate independent. This means that the text will scroll faster at a higher framerate and slower and a lower framerate, when really it should be the same scroll speed.
Screenshots/Videos
Below are videos of what this problem looks like at 60 FPS and 200 FPS. Luckily, this PR fixes this problem!
results.screen.60.fps.mp4
results.screen.200.fps.mp4