Skip to content

Conversation

@TechnikTil
Copy link
Contributor

@TechnikTil TechnikTil commented Nov 24, 2025

Vocabulary

  • Nested Substate
    • A substate initialized on top of an already existing substate.
    • Ex. Most Sticker Transitions, any substate on PlayState when using the chart editor.
  • Recursive
    • A procedure or rule that is repeated.
    • Ex. Friday Night' Funkin recursively searching the game for scripted classes.
  • Scoped Module
    • A Module that can only run in a specific state.

These are your vocabulary words for today's PR, thank you for re-experiencing the horrors of Language Arts class.

Description

Unfortunately, the ModuleHandler callEvent method only checks if the current state or substate on that state is active. This means that any nested substate won't activate scoped modules.

This PR makes sure this behavior doesn't happen by doing a recursive search through every substate, and checking if the substate is the state specified for the scoped module.

@github-actions github-actions bot added status: pending triage Awaiting review. size: medium A medium pull request with 100 or fewer changes. pr: haxe PR modifies game code. labels Nov 24, 2025
@AbnormalPoof AbnormalPoof added the type: minor bug Involves a minor bug or issue. label Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: haxe PR modifies game code. size: medium A medium pull request with 100 or fewer changes. status: pending triage Awaiting review. type: minor bug Involves a minor bug or issue.

Development

Successfully merging this pull request may close these issues.

2 participants