[ENHANCEMENT] Improved offsets for BF and GF animations #237
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Associated Funkin PR
Divided into parts of #79
Part 1: Current
Part 2: #238
Part 3: #239
Linked Issues
One issue that I mentioned in FunkinCrew/Funkin/issues/3105
Description
Improved almost all offsets for each BF and GF animation (except those using spritemaps)
Changed the order of some animations in the
.jsonfiles to make it a little more intuitive. It follows this order:Added
"hit-hold"tobf-car.jsonAdded
"hey"tobf-christmas.jsonRemoved
"singUP"fromgf-pixel.json, an unused animation that was probably added by mistakeRemoved a possibly unintentional
"singUP"animation that had"prefix": "BF Dies with GF"inbf-holding-gf.jsonI used the foot that was pointing towards the camera in the
idleanimation as a reference in most animations, in others I used the other one.If you notice any errors or changes you don't like, let me know so I can change them.
Screenshots/Videos
Video showing most of the offsets improvements for the characters:
https://youtu.be/KMfvUnbRmwQ