Skip to content

Conversation

@NotHyper-474
Copy link
Contributor

@NotHyper-474 NotHyper-474 commented Aug 27, 2025

Associated Funkin PR

N/A

Linked Issues

N/A (or none that I can recall...)

Description

Basically pre-caches the sprite when their sprite group is created so that it doesn't cause a stutter when it first generates a Tankman.

The caching system definitely needs to be looked into on why it's not being able to cache all images though, but this will suffice for now.

Screenshots/Videos

@github-actions github-actions bot added status: pending triage Awaiting review. size: tiny A tiny pull request with 4 or fewer changes. pr: hscript PR modifies game scripts. and removed size: tiny A tiny pull request with 4 or fewer changes. labels Aug 27, 2025
@NotHyper-474 NotHyper-474 force-pushed the lagfix/tankmenspritegroup!!!!!!!!!!!!!!!!!!!!!!!!!!! branch from 0084906 to a341d70 Compare August 27, 2025 21:33
@github-actions github-actions bot added the size: tiny A tiny pull request with 4 or fewer changes. label Aug 27, 2025
@Hundrec Hundrec added type: optimization Involves a performance issue or a bug which causes lag. status: reviewing internally Under consideration and testing. and removed status: pending triage Awaiting review. labels Aug 27, 2025
@Hundrec Hundrec changed the base branch from develop to dummy/develop-v0.7.4 September 6, 2025 18:44
@Hundrec Hundrec added status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. and removed status: reviewing internally Under consideration and testing. labels Sep 6, 2025
@Hundrec Hundrec modified the milestones: 0.7.4, 0.7.5 Sep 6, 2025
@Hundrec Hundrec merged commit 8bd4a54 into FunkinCrew:dummy/develop-v0.7.4 Sep 6, 2025
7 checks passed
@NotHyper-474 NotHyper-474 deleted the lagfix/tankmenspritegroup!!!!!!!!!!!!!!!!!!!!!!!!!!! branch September 6, 2025 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: hscript PR modifies game scripts. size: tiny A tiny pull request with 4 or fewer changes. status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. type: optimization Involves a performance issue or a bug which causes lag.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants