[BUGFIX] Fix A-Bot visualizer freezing when restarting the song #246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
status: pending triage
Hundrec
added
type: minor bug
Hundrec
changed the title
Contributor
|
Hell yeah! |
|
You are legend |
Hundrec
force-pushed
the
why-destroy-when-you-can-hide
branch
from
7ef42a2 to
ba3a8b0
Compare
Hundrec
added
status: reviewing internally
Hundrec
added
status: accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Associated Funkin PR
N/A
Linked Issues
Closes FunkinCrew/Funkin#5885
Description
A-Bot's visualizer assumes the song is as the song position 0 when restarting the song and that the song is playing, so it uses the frequencies of that timestamp. Upon messing with it I've realized that setting
abotViz.alphato 0 (NOTHING !!!) after restarting seems to hide this error perfectly well.Setting
visibleto False... wouldn't work here since it takes the visibility values from nene inonUpdate.Screenshots/Videos
you.disgusting.orange.boy.and.your.awful.way.of.flipping.me.off.mp4