Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI breakage following macos-12 runner image deprecation #489

Merged
merged 2 commits into from
Jan 13, 2025
+3 −2
Merged

Fix CI breakage following macos-12 runner image deprecation #489

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dac4d6f
Use `macos-13` instead of `macos-12` runner image following deprecation
jgiannuzzi Jan 12, 2025
375bd46
Also notify on run cancellation
jgiannuzzi Jan 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ jobs:
if: github.event_name == 'schedule' || github.event_name == 'push' || github.event.pull_request.head.repo.id != github.event.pull_request.base.repo.id
strategy:
matrix:
os: [ubuntu-20.04, macos-12, windows-2022]
os: [ubuntu-20.04, macos-13, windows-2022]
arch: [x64, arm64]
exclude:
- os: windows-2022
Expand Down Expand Up @@ -218,7 +218,7 @@ jobs:
test-nuget:
strategy:
matrix:
os: [ubuntu-20.04, ubuntu-22.04-arm64, macos-12, macos-13, macos-14, windows-2022]
os: [ubuntu-20.04, ubuntu-22.04-arm64, macos-13, macos-14, windows-2022]
dotnet: [netcoreapp3.1, net6.0, net7.0, net8.0]
include:
- os: windows-2022
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/nudge.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,3 +15,4 @@ jobs:
uses: pavlovic-ivan/octo-nudge@v2
with:
webhooks: ${{ secrets.NUDGE_WEBHOOKS }}
conclusions: failure,cancelled
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @pavlovic-ivan , it turns out that cancelled is not a valid conclusions value -> https://github.com/pavlovic-ivan/octo-nudge/blob/329060af1fb848e1ab0b3350dac3f5f5d9487eb9/util/index.js#L4. Is something that we could add to the nudge action or maybe it is not really possible to react on cancelled conclusions?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Marcin. cancelled is not currently supported by the octo-nudgde. However, i can add it and support it

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @marcin-krystianc @jgiannuzzi . Please update the version of the octo-nudge action to v3. You should get the notifications for cancelled runs as well. Do let me know if it's not working (i've tested it, and it works in my setup).

Loading