fix「字庫練習」輸入框：末題再答、題目重碼、下一題效率、提示效率 #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… again
It is possible to input a character from other questions.
However, it was not possible to input a character from any passed question,
because these characters were removed from the input table.
This caused an issue for the last question,
since the "next" question of the last question is currently itself.
This issue is fixed by separating the input table and the question list.
* MapCharacterTable()
* add this.questList (init-ed to have the same content as this.table)
* MapCharacterTable.prototype.getCharacterAndAlphabet()
* make the previous question deleted from this.questList instead
This prevents the user from wrongly pressing Space right after pressing Enter.
* inputBar.oninput()
* reset visualBar.node.textContent on pressing Enter
…dvancing O(1) time
The question 叭 (口金; rc) was inaccessible
due to its Cangjie code being the same as 只 (口金; rc).
This issue is fixed by using an Array for MapCharacterTable.questList.
* MapCharacterTable()
* make this.questList an array (LIFO)
* reverse the iteration of `this.questList`-building `for` loop
* MapCharacterTable.prototype.getCharacterAndAlphabet()
* simplify question advancing by using Array.prototype.pop()
* overwrite input table with the answer of the current question
for handling characters with the same Cangjie code within the same stage
* initialize hintBar with attrs hintState & hideState
* hintBar.newHintState()
* initialize this.hintState & this.hideState
* hintBar.hintCharacter()
* cache hintState into `this`
* cache hideState into `this`
* avoid string comparisons by accessing & modifying this.hideState instead
IepIweidieng
force-pushed
the
fix-composeExercise-input-behavior
branch
2 times, most recently
from
df41973
to
e5370ac
Compare
IepIweidieng
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rc）。