Skip to content

Conversation

@smk762
Copy link
Collaborator

@smk762 smk762 commented Oct 28, 2025

Closes #3277

image

There is a challenge with populating the makerbot lists, as they only include coins with price data - and if a coin is not active, this data is not cached. To overcome this, "add assets" buttons have been added as a footer to the dropdowns, giving the user a pathway to remedy the lack.

To test:

  • login, enable makerbot
  • go to makerbot form
  • Confirm only activated, funded coins with price data are listed in the sell drop down
  • Confirm the "add assets" footer in the sell drop down navigates to the "add assets" view.
  • Confirm only activated coins with price data are listed in the buy drop down
  • Confirm the "add assets" footer in the buy drop down navigates to the "add assets" view.

@smk762 smk762 self-assigned this Oct 28, 2025
@smk762 smk762 added P1 Major issue needs to be fixed UX Cosmetic or flow efficiency enhancements for improved User Experience bot related to bot trading labels Oct 28, 2025
@smk762 smk762 changed the base branch from main to dev October 28, 2025 15:18
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 28, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch makerbot-selections

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

github-actions bot commented Oct 28, 2025

Visit the preview URL for this PR (updated for commit 2af2ed9):

https://walletrc--pull-3284-merge-dhymz4q5.web.app

(expires Mon, 10 Nov 2025 05:55:11 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: f66a4ff03faa546f12f0ae5a841bd9eff2714dcc

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@CharlVS CharlVS added this to the v0.9.3 Release milestone Nov 2, 2025
CharlVS added a commit that referenced this pull request Nov 2, 2025
@smk762 smk762 modified the milestones: v0.9.3 Release, v0.9.4 Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot related to bot trading P1 Major issue needs to be fixed UX Cosmetic or flow efficiency enhancements for improved User Experience

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Makerbot sell list only contains activated coins

3 participants