-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add error message suggesting aliases if no matching refName found #3199
base: main
Are you sure you want to change the base?
Conversation
I think this is not an "Erroneous" condition. If it is helpful to have a small indicator somehow, that might be ok, but I would not display a red error message. There are many conditions why an adapter might not have data for a given refname |
Codecov Report
@@ Coverage Diff @@
## track_message_updates #3199 +/- ##
======================================================
Coverage 59.48% 59.48%
======================================================
Files 671 671
Lines 28735 28744 +9
Branches 6968 6971 +3
======================================================
+ Hits 17093 17099 +6
- Misses 11320 11324 +4
+ Partials 322 321 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
d34d094
to
cf07930
Compare
I added a change that uses #3200 to make it an informational message instead of an error. |
I think this may still be a bit too bold of a message for what can be normal conditions for a track
I am sympathetic to the issue because I know that users run into this type of situation frequently. But, I just don't want to be presumptive about the data visualization. Some ideas
|
This is an attempt to help users know that they may need to configure refName aliases. Currently, if aliases are not set up and the refName doesn't match, it shows an empty display. This adds an error message by:
FeatureRendererType.ts
it callsgetFeaturesInRegion
on the adapter instead ofgetFeatures
. This is basically a wrapper aroundgetFeatures
that includes a check to see if it has data for the refName.hasDataForRefName
to return true ifrefNames.length === 0
. That way if the adapter does not support retrieving refNames, no error will be thrown.getFeaturesInRegion
if there is no data for the refName, with a suggestion to configure refName aliases.The result looks like this: