Massive client overhaul #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoids pushing stuff
Including a very large refactor to my state management to stop doing dumb stuff
General organizational changes to save my sanity
I've intentionally chosen to move away from the provider package here - I know that it's the recommended way to manage state, but this app feels simple enough that managing a few callbacks and staying as close to "vanilla" flutter as possible is worthwhile. I may walk this choice back in the future and move back to one of the many abstraction libraries.
There are a couple remaining, namely: 1. The title of the details pane 2. The "At a Glance" indicators in the detaiil pane These both only overflow when the window is resized extremely smally, which is not intended and I am OK with having it look funky.
This works... surprisingly well out of the box
This now supports updating as you change thinfs for various fields, like displaying the new image and all that jazz
Images are copied to a special directory to ensure that they still exist in the same place at the next app load
This reverts commit 544f86b.
yay! A name that isn't totally made up!
- organize imports - organize struct ordering and such - basically whatever the lsp code actions want
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an incredibly bad PR practice, good thing it's just me!
This basically just rewrites the entire client app to be local-only