-
Notifications
You must be signed in to change notification settings - Fork 62
GPII-3780: Solve "windows.desktopBackground" and ""windows.desktopBackgroundColor" transformations issues #754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 8 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
4888c7b
GPII-3780: Fixed 'com.microsoft.windows.desktopBackgroundColor' and '…
JavierJF e008b49
GPII-3780: Improved tests for 'windows.desktopBackground' and 'window…
JavierJF 2030606
GPII-3780: Added new preference sets for 'windows.desktopBackgroundCo…
JavierJF 4f910c6
GPII-3780: Solved linter issues
JavierJF c9ff113
Merge branch 'master' of https://github.com/GPII/universal into GPII-…
JavierJF 13d4b5a
GPII-3780: Simplified transformation due to GPII-3784 being solve
JavierJF a9d702e
GPII-3780: Improve the tranformation for "ImageConfig" in win32.json5.
cindyli 946756e
Merge pull request #1 from cindyli/GPII-3780
JavierJF fd9a73f
Merge branch 'master' of https://github.com/GPII/universal into GPII-…
JavierJF 0b705aa
GPII-3780: Removed unnecessary transform due to GPII-3784 being alrea…
JavierJF 664fce8
GPII-3780: Changed preferences for 'test-user' to change to different…
JavierJF File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| // # Bryan.json5 | ||
| // | ||
| // This preference sets changes the desktop wallpaper with another default Windows 10 one. | ||
| // | ||
| // ## Testing | ||
| // | ||
| // Windows desktop background should be replaced by with other one. | ||
| // | ||
| { | ||
| "flat": { | ||
| "name": "Bryan", | ||
| "contexts": { | ||
| "gpii-default": { | ||
| "name": "Default preferences", | ||
| "preferences": { | ||
| "http://registry.gpii.net/applications/com.microsoft.windows.desktopBackground": { | ||
| "Image": "C:\\Windows\\Web\\Wallpaper\\Theme1\\img3.jpg" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| // # Bryan.json5 | ||
| // | ||
| // This preference sets changes the desktop wallpaper with another default Windows 10 one, | ||
| // at sets the Scaling to "Fill". | ||
| // | ||
| // ## Testing | ||
| // | ||
| // Windows desktop background should be replaced by with other one, and scaling set to "Fit". | ||
| // | ||
| { | ||
| "flat": { | ||
| "name": "Bryan", | ||
| "contexts": { | ||
| "gpii-default": { | ||
| "name": "Default preferences", | ||
| "preferences": { | ||
| "http://registry.gpii.net/applications/com.microsoft.windows.desktopBackground": { | ||
| "Scaling": "Fill", | ||
| "Image": "C:\\Windows\\Web\\Wallpaper\\Theme1\\img3.jpg" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| // # Daniel-raw.json5 | ||
| // | ||
| // This preference sets the desktop background to a solid color. This is the same | ||
| // preference set as Daniels one, but without using the convenience transforms. | ||
| // | ||
| // ## Testing | ||
| // | ||
| // Windows desktop background should be replace by a green image. | ||
| // | ||
| { | ||
| "flat": { | ||
| "name": "Daniel-raw", | ||
| "contexts": { | ||
| "gpii-default": { | ||
| "name": "Default preferences", | ||
| "preferences": { | ||
| "http://registry.gpii.net/applications/com.microsoft.windows.desktopBackgroundColor": { | ||
| "ImageConfig": { | ||
| "path": "pvParam", | ||
| "value": "" | ||
| }, | ||
| "SolidColorConfig": { | ||
| "value": { "r": 67, "g": 187, "b": 19 } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| { | ||
| "flat": { | ||
| "contexts": { | ||
| "gpii-default": { | ||
| "name": "Default preferences", | ||
| "preferences": { | ||
| "http://registry.gpii.net/applications/com.microsoft.windows.desktopBackgroundColor": { | ||
| "SolidColor": { "r": 67, "g": 187, "b": 19 } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| { | ||
| "flat": { | ||
| "contexts": { | ||
| "gpii-default": { | ||
| "name": "Default preferences", | ||
| "preferences": { | ||
| "http://registry.gpii.net/applications/com.microsoft.windows.desktopBackground": { | ||
| "Scaling": "Fill", | ||
| "Image": "C:\\Windows\\Web\\Wallpaper\\Theme1\\img3.jpg" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| { | ||
| "flat": { | ||
| "contexts": { | ||
| "gpii-default": { | ||
| "name": "Default preferences", | ||
| "preferences": { | ||
| "http://registry.gpii.net/applications/com.microsoft.windows.desktopBackground": { | ||
| "Scaling": "Fit", | ||
| "Image": "C:\\Windows\\Web\\Wallpaper\\Theme1\\img2.jpg" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| { | ||
| "flat": { | ||
| "contexts": { | ||
| "gpii-default": { | ||
| "name": "Default preferences", | ||
| "preferences": { | ||
| "http://registry.gpii.net/applications/com.microsoft.windows.desktopBackground": { | ||
| "Scaling": "Tile", | ||
| "Image": "C:\\Windows\\Web\\Wallpaper\\Theme1\\img4.jpg" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this transform is no longer required, right? See https://issues.gpii.net/browse/GPII-3784
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You were right, I have changed it and things are being tested in CI, I have also tested the Windows pull in local, and I will also re-trigger Windows CI once this is done.