This repository was archived by the owner on Jun 2, 2025. It is now read-only.
Improved Polling Version 1#170
Merged
Merged
Conversation
- loop through the dictionary to build both the SET expression string and variable value dictionary
- writing a new document scenario - update existing document scenario
- database updates - write initial document id and status in s3 file upload
Co-authored-by: halprin <halprin@users.noreply.github.com>
Co-authored-by: halprin <halprin@users.noreply.github.com>
…ument-extractor-poc into task-get-results-improvement
halprin
reviewed
May 8, 2025
Member
halprin
left a comment
halprin
left a comment
There was a problem hiding this comment.
Two small things, then I think it is good.
| from src.storage import CloudStorage | ||
|
|
||
|
|
||
| # rename create_document |
Member
There was a problem hiding this comment.
Oh, let's remove this comment since we thought better of this.
Comment on lines
34
to
36
| def write_document_initialization(document_id: str, status: str, database: Database = None): | ||
| item_to_store = {"document_id": document_id, "status": "processing"} | ||
| database.write_document(item_to_store) |
Member
There was a problem hiding this comment.
We can remove this function, right?
Contributor
Author
Good catch, these are fixed now. |
halprin
approved these changes
May 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request