Refactor Non-api Gateway Facing Lambda's

backend/src/external/aws/lambdas/sqs_dynamo_writer.py

@@ -18,9 +18,6 @@
 
 
 def lambda_handler(event, context):
-    failure = False
-    exception_message = "An internal error happened while trying to save a document to the database"
-
     for record in event["Records"]:
         try:
             message_body = json.loads(record["body"])
@@ -34,17 +31,9 @@ def lambda_handler(event, context):
             sqs_client = appContext.implementation(SQSClient)
             sqs_client.delete_message(QueueUrl=sqs_queue_url, ReceiptHandle=record["receiptHandle"])
         except Exception as e:
+            exception_message = "An internal error happened while trying to save a document to the database"
             logging.error(exception_message)
             logging.exception(e)
-            failure = True
-
-    if failure:
-        return {
-            "statusCode": 500,
-            "body": json.dumps(exception_message),
-        }
-
-    return {
-        "statusCode": 200,
-        "body": json.dumps("Processing complete"),
-    }
+            raise
+
+    logging.info("Process complete")

backend/src/external/aws/lambdas/text_extractor.py

@@ -1,4 +1,3 @@
-import json
 import logging
 import os
 
@@ -36,28 +35,16 @@ def lambda_handler(event: events.S3Event, context: lambda_context.Context):
         exception_message = f"Failed to find the file {s3_url}"
         logging.error(exception_message)
         logging.exception(e)
-        return {
-            "statusCode": 500,
-            "body": json.dumps(exception_message),
-        }
+        raise
     except OcrException as e:
         exception_message = f"Failed OCR of {s3_url}"
         logging.error(exception_message)
         logging.exception(e)
-        return {
-            "statusCode": 500,
-            "body": json.dumps(exception_message),
-        }
+        raise
     except Exception as e:
         exception_message = "Failed to send message to queue"
         logging.error(exception_message)
         logging.exception(e)
-        return {
-            "statusCode": 500,
-            "body": json.dumps(exception_message),
-        }
-
-    return {
-        "statusCode": 200,
-        "body": json.dumps("Document processed successfully and sent to SQS"),
-    }
+        raise
+
+    logging.info("Document processed successfully and sent to SQS")