add mdtranslator as transformation app #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rshewitt
force-pushed
the
feature/add-mdtranslator
branch
from
2ab08d5
to
fdf1239
Compare
rshewitt
force-pushed
the
feature/add-mdtranslator
branch
from
32f8aca
to
4616902
Compare
jbrown-xentity
previously approved these changes
Dec 21, 2023
There was a problem hiding this comment.
Looks good, separating the quick unit tests from integration tests I really like. Let's us separate the "I broke something with my changes" from "something is broken if it's deployed now", and allows for more nuanced review of those integration tests (ie they might be more fragile)
Coverage Report
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
robert-bryson
previously approved these changes
Dec 22, 2023
|
Friendly reminder to bump the version if this is intended to be consumed as a new version on pypi. |
robert-bryson
force-pushed
the
feature/add-mdtranslator
branch
from
5ff2123
to
b107f0a
Compare
robert-bryson
previously approved these changes
Dec 22, 2023
jbrown-xentity
approved these changes
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Related to #4565
About
Add mdtranslator app to transform fgdc sources into iso19115
PR TASKS