Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

push to cloud.gov #35

Merged
merged 5 commits into from
Feb 27, 2024
Merged

push to cloud.gov #35

merged 5 commits into from
Feb 27, 2024

Conversation

FuhuXia
Copy link
Member

@FuhuXia FuhuXia commented Feb 26, 2024

Pull Request

Related to

About

An app can be pushed cloud.gov

  • no route
  • zero instance
  • can run task such as cf run-task datagov-harvesting-logic -c '/home/vcap/app/scripts/smoke-test.py'
  • can start the app by cf scale datagov-harvesting-logic -i 1 and ssh into it
  • develop branch will push the app to development cloud.gov space
  • main branch will push the app to staging then prod cloud.gov space

PR TASKS

  • The actual code changes.
  • Tests written and passed.
  • Any changes to docs?
  • Bumped version number in pyproject.toml (also checked on PyPi).

@FuhuXia FuhuXia marked this pull request as draft February 26, 2024 17:46
Copy link

github-actions bot commented Feb 26, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
harvester
   __init__.py10100% 
   ckan_utils.py4222 95%
   harvest.py4116767 84%
   utils.py4377 84%
TOTAL4977685% 

Tests Skipped Failures Errors Time
22 0 💤 0 ❌ 0 🔥 2.073s ⏱️

@krishnasanaka krishnasanaka marked this pull request as ready for review February 26, 2024 17:57
@FuhuXia FuhuXia marked this pull request as draft February 26, 2024 17:58
@FuhuXia FuhuXia marked this pull request as ready for review February 27, 2024 18:05
@FuhuXia FuhuXia requested a review from a team February 27, 2024 18:05
Copy link
Contributor

@btylerburton btylerburton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

@rshewitt rshewitt merged commit 16fe2bd into main Feb 27, 2024
7 checks passed
@rshewitt rshewitt deleted the cf-push branch February 27, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants